test: add WebSocket terminal I/O route tests#43
Merged
Ark0N merged 1 commit intofeat/ws-terminal-io-upstreamfrom Mar 14, 2026
Merged
test: add WebSocket terminal I/O route tests#43Ark0N merged 1 commit intofeat/ws-terminal-io-upstreamfrom
Ark0N merged 1 commit intofeat/ws-terminal-io-upstreamfrom
Conversation
16 tests covering session-not-found close code, terminal output with DEC 2026 sync markers, client input forwarding, resize bounds validation, malformed message handling, and connection cleanup of session event listeners. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/web/routes/ws-routes.tssession.write(), MAX_INPUT_LENGTH enforcement, malformed JSON resilience, resize bounds validation (min/max/non-integer/negative), and connection cleanup of session event listeners@fastify/websocketandwsclient sinceapp.inject()doesn't support WebSocket upgradesTest plan
npx vitest run test/routes/ws-routes.test.tsnpx tsc --noEmitnpm run lintnpm run format:check🤖 Generated with Claude Code